Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: QuickEmbed component #1306

Merged
merged 5 commits into from
May 6, 2023
Merged

feat: QuickEmbed component #1306

merged 5 commits into from
May 6, 2023

Conversation

josephaxisa
Copy link
Contributor

@josephaxisa josephaxisa commented May 5, 2023 •
edited
Loading

To test:

  1. run yarn && yarn build
  2. navigate to packages/embed-playground
  3. run yarn play
  4. In your browser, visit https://localhost:8080/dashboards/42 or https://localhost:8080/explore/thelook/orders or https://localhost:8080/looks/42 and authenticate.
  5. Play around with having different existing url params (including theme)

jkaster
jkaster approved these changes May 6, 2023
View reviewed changes
Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good for the next phase.

@josephaxisa josephaxisa merged commit 4c78712 into main May 6, 2023
@josephaxisa josephaxisa deleted the jax/quickembed branch May 6, 2023 01:28
This was referenced May 6, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaster jkaster jkaster approved these changes

@bryans99 bryans99 Awaiting requested review from bryans99

@zeckertG zeckertG Awaiting requested review from zeckertG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephaxisa @jkaster